Update teleport_deactivate_user to use pg_auth_members#60190
Merged
Conversation
github-actions
bot
added
the
database-access
greedy52
approved these changes
Oct 14, 2025
GavinFrazar
approved these changes
Oct 14, 2025
public-teleport-github-review-bot
bot
removed the request for review
from gabrielcorado
Contributor
mmcallister
pushed a commit
that referenced
this pull request
Nov 6, 2025
mmcallister
pushed a commit
that referenced
this pull request
Nov 19, 2025
mmcallister
pushed a commit
that referenced
this pull request
Nov 20, 2025
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moving away from
pg_has_role, which matches inherited roles, topg_auth_membersthat only contains direct assignements.I considered changing
e2etests to cover this case, but the isolated character of databases makes it difficult to observe meaningful differences in behaviour.I ended up testing it manually in different scenarios.
Closes #55395
Changelog: Fixed issue with inherited roles interfering with auto role provisioning cleanup in Postgres