Adding tctl scoped tokens family of subcommands#60035
Merged
Conversation
eriktate
force-pushed
the
eriktate/scoped-join-tokens-backend
branch
from
cb28a3e to
d960a90
Compare
eriktate
force-pushed
the
eriktate/tctl-scoped-tokens
branch
from
ceb6d07 to
3360767
Compare
rosstimothy
reviewed
Oct 9, 2025
eriktate
force-pushed
the
eriktate/scoped-join-tokens-backend
branch
from
7849329 to
703c043
Compare
eriktate
force-pushed
the
eriktate/tctl-scoped-tokens
branch
2 times, most recently
from
ad2ff69 to
1810774
Compare
fspmarshall
reviewed
Oct 15, 2025
Contributor
fspmarshall
left a comment
fspmarshall
left a comment
There was a problem hiding this comment.
My general feedback would be that brevity is the soul of wit. There's a lot here that just isn't necessary yet, and a lot of bridges I'd rather cross when we come to them. Can we pair this down to the essentials (ttl, role, etc)?
eriktate
force-pushed
the
eriktate/scoped-join-tokens-backend
branch
from
b33fac5 to
9fb4699
Compare
eriktate
force-pushed
the
eriktate/tctl-scoped-tokens
branch
from
1810774 to
e465ec9
Compare
eriktate
force-pushed
the
eriktate/scoped-join-tokens-backend
branch
3 times, most recently
from
5f9bf01 to
735c60e
Compare
eriktate
force-pushed
the
eriktate/tctl-scoped-tokens
branch
3 times, most recently
from
2b17244 to
39d932c
Compare
rosstimothy
reviewed
Oct 17, 2025
eriktate
force-pushed
the
eriktate/scoped-join-tokens-backend
branch
from
a1dbcc3 to
7846fe2
Compare
eriktate
force-pushed
the
eriktate/tctl-scoped-tokens
branch
from
39d932c to
e20ed0e
Compare
eriktate
force-pushed
the
eriktate/scoped-join-tokens-backend
branch
from
7846fe2 to
0ee1260
Compare
eriktate
force-pushed
the
eriktate/tctl-scoped-tokens
branch
6 times, most recently
from
a06ffaa to
b4d17ad
Compare
eriktate
force-pushed
the
eriktate/tctl-scoped-tokens
branch
from
b4d17ad to
3d2df71
Compare
eriktate
force-pushed
the
eriktate/scoped-join-tokens-backend
branch
from
690009e to
4b2557b
Compare
eriktate
force-pushed
the
eriktate/tctl-scoped-tokens
branch
from
3d2df71 to
53825d3
Compare
rosstimothy
approved these changes
Oct 21, 2025
eriktate
force-pushed
the
eriktate/scoped-join-tokens-backend
branch
from
4b2557b to
e810e5a
Compare
eriktate
force-pushed
the
eriktate/tctl-scoped-tokens
branch
from
53825d3 to
f2d60b0
Compare
Base automatically changed from
eriktate/scoped-join-tokens-backend
to
master
October 22, 2025 04:35
eriktate
force-pushed
the
eriktate/tctl-scoped-tokens
branch
from
f2d60b0 to
6662596
Compare
nklaassen
reviewed
Oct 24, 2025
nklaassen
approved these changes
Oct 27, 2025
eriktate
force-pushed
the
eriktate/tctl-scoped-tokens
branch
from
3d97d66 to
73b2a30
Compare
public-teleport-github-review-bot
bot
removed request for
greedy52 and
kiosion
eriktate
added
the
no-changelog
eriktate
added a commit
that referenced
this pull request
Oct 29, 2025
fspmarshall
pushed a commit
that referenced
this pull request
Oct 31, 2025
eriktate
added a commit
that referenced
this pull request
Nov 4, 2025
mmcallister
pushed a commit
that referenced
this pull request
Nov 6, 2025
mmcallister
pushed a commit
that referenced
this pull request
Nov 19, 2025
mmcallister
pushed a commit
that referenced
this pull request
Nov 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the following subcommands to
tctl:It largely mimics the existing
tctl tokens ...subcommands while adding new fields for assigning scopes or filtering by scopes.