[refactor] client.NewMCPServerDialer#60020
Merged
Conversation
greedy52
added
no-changelog
github-actions
Bot
added
size/md
tsh
greedy52
force-pushed
the
STeve/56588_mcp_server_dialer
branch
from
63c8c8e to
3efb629
Compare
Tener
approved these changes
Oct 8, 2025
Contributor
Tener
left a comment
Tener
left a comment
There was a problem hiding this comment.
I'm rather keen on having standalone test coverage for all shared utilities like the ones added in this PR.
gabrielcorado
approved these changes
Oct 8, 2025
public-teleport-github-review-bot
Bot
removed request for
GavinFrazar and
espadolini
greedy52
force-pushed
the
STeve/56588_mcp_server_dialer
branch
from
b5df742 to
a9b0f27
Compare
greedy52
added a commit
that referenced
this pull request
Oct 23, 2025
* [refactor] client.NewMCPServerDialer * TestVerifyTLSCertLeafExpiry * TestMatchResourcesByFilters * fix typo * fix lint
6 tasks
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Oct 27, 2025
* [MCP] server-side SSE support (#56051) * MCP access part 12: server-side SSE support * parse uri for determining transport type * fix pointer, atomic, and parse error � Conflicts: � lib/srv/mcp/server.go * fix schema, etc * switch to golang internal mcp sse parsing * remove ParentCtx from logging * fix build and address comments * [mcp] refactor jwt token and app header rewrite logic (#58601) * [mcp] mcputils for streamable http (#58764) * [mcp] mcputils for streamable http * fix flaky test * use utils.ReadAtMost and fmt.Appendf * add a marshal function for event * fix spell * [mcp] update audit events for streamable HTTP transport (#59155) * [mcp] update audit events for streamable HTTP transport * nolint for unused functions for now, they will be used in next PR * [mcp] server handler for streamable HTTP transport (#59499) * [mcp] server handler for streamable hTTP transport * review comments round 1 * add comments and fix flaky test * [mcp] bump mcp-go version (#59500) * [mcp] bump mcp-go version * fix IO transport by explicit start * [mcp] add server prometheus metrics (#59773) * [mcp] add server prometheus metrics * remove TODO and nolint * use counter where possible and limit known methods * move reporting test to individual tests * nolint for "cancelled" * Fix an issue docker container launched by MCP commands are not removed sometimes (#59879) * Fix an issue docker container launched by MCP commands are not removed sometimes * switch to math/rand/v2 * add "tsh proxy mcp" command (#59968) * [refactor] client.NewMCPServerDialer (#60020) * [refactor] client.NewMCPServerDialer * TestVerifyTLSCertLeafExpiry * TestMatchResourcesByFilters * fix typo * fix lint * mcputils for streamable HTTP transport conversion (#60024) * mcputils for streamable HTTP transport conversion * remove need of context from mcptest functions * add test for notification * [mcp] "tsh mcp connect" support for streamable HTTP (#60120) * implement "tsh mcp connect" for streamable HTTP * wait for 5s just to be conservative * [mcp] Web UI and Teleport Connect adjustments for SSE and Streamable HTTP MCP servers (#60281) * [mcp] Web UI and Teleport Connect adjustments for SSE and Streamable HTTP MCP servers * review comments * [mcp] fix some edge cases for streamable HTTP (#60286) * [mcp] add JWT and rewrite headers support for SSE MCP servers (#60320) * fix go.mod to match master * fix lint and ut
rhammonds-teleport
pushed a commit
that referenced
this pull request
Nov 6, 2025
* [refactor] client.NewMCPServerDialer * TestVerifyTLSCertLeafExpiry * TestMatchResourcesByFilters * fix typo * fix lint
mmcallister
pushed a commit
that referenced
this pull request
Nov 19, 2025
* [refactor] client.NewMCPServerDialer * TestVerifyTLSCertLeafExpiry * TestMatchResourcesByFilters * fix typo * fix lint
mmcallister
pushed a commit
that referenced
this pull request
Nov 20, 2025
* [refactor] client.NewMCPServerDialer * TestVerifyTLSCertLeafExpiry * TestMatchResourcesByFilters * fix typo * fix lint
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
related:
no real logic change. just moving some functions from
client.TeleportClientto a dedicatedclient.MCPServerDialerwith some caching capability