[v16] Refactor tracessh.Client to cover untraced paths - session requests#59789
Merged
Joerger merged 3 commits intobranch/v16from Oct 6, 2025
Merged
[v16] Refactor tracessh.Client to cover untraced paths - session requests#59789Joerger merged 3 commits intobranch/v16from
Joerger merged 3 commits intobranch/v16from
Conversation
…#59291) * Move ssh session helper into a separate file. * Replace ssh session ChannelRequestCallback with a more x/crypto/ssh-like approach to request channel handling. * Update comments. * Move new request handling logic into tracessh client. * Fix goroutine leaks with refactors. * Add test. * Cleanup. * Rename methods. * Fix lint. * Address comments; Fix error and cleanup handling issues in tracing ssh tests. * Increase test timeouts. * Fix test data race.
Joerger
added
backport
no-changelog
capnspacehook
approved these changes
Oct 2, 2025
rosstimothy
approved these changes
Oct 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport #59291 to branch/v16