Skip to content

Add skip inactivity button in SSH session recording playback#59492

Merged
ryanclark merged 2 commits intomasterfrom
ryan/add-skip-inactivity-button
Sep 29, 2025
Merged

Add skip inactivity button in SSH session recording playback#59492
ryanclark merged 2 commits intomasterfrom
ryan/add-skip-inactivity-button

Conversation

@ryanclark
Copy link
Copy Markdown
Member

image

This adds a skip inactivity button in the top right of the player when the timeline is in a period of inactivity. I designed CurrentEventInfo to show different types of events, but inactivity is the only one we surface at the moment.

changelog: Periods of inactivity in SSH session playback can now be skipped

Comment on lines +31 to +32
const EventsList = styled.div`
display: flex;
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not use styled(Flex)


const items: ReactNode[] = [];

for (const [index, event] of currentEvents.entries()) {
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

im curious if there is any reason to use this over something like currentEvents.forEach((event, index) => or just a preference?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Preference, I hate .forEach lol

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair enough

@ryanclark ryanclark force-pushed the ryan/add-skip-inactivity-button branch from 7af4379 to 7a83004 Compare September 29, 2025 11:23
@ryanclark ryanclark enabled auto-merge September 29, 2025 11:23
@ryanclark ryanclark added this pull request to the merge queue Sep 29, 2025
Merged via the queue into master with commit 3398d3d Sep 29, 2025
40 checks passed
@ryanclark ryanclark deleted the ryan/add-skip-inactivity-button branch September 29, 2025 12:06
@backport-bot-workflows
Copy link
Copy Markdown
Contributor

@ryanclark See the table below for backport results.

Branch Result
branch/v18 Create PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants