[v18] Fix session ID env var handling for joining sessions#59472
Merged
Joerger merged 1 commit intobranch/v18from Sep 25, 2025
Merged
[v18] Fix session ID env var handling for joining sessions#59472Joerger merged 1 commit intobranch/v18from
Joerger merged 1 commit intobranch/v18from
Conversation
* Refactor server session ID logic; Separate join and open session flows. * Remove unused client node session ID. * Fix backwards compatibility. * Fix tests and lint. * Update deprecation TODO. * Fix failing test caused by delayed association with join session. * fix session ID for git events --------- Co-authored-by: STeve (Xin) Huang <huangin52@gmail.com>
github-actions
bot
requested review from
espadolini,
gabrielcorado and
greedy52
greedy52
approved these changes
Sep 23, 2025
gabrielcorado
approved these changes
Sep 23, 2025
public-teleport-github-review-bot
bot
removed the request for review
from espadolini
greedy52
approved these changes
Sep 23, 2025
Joerger
added
no-changelog
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport #59294 to branch/v18
Changelog: Fixed a bug where session IDs were tied to the client connection, resulting in issues when combined with multiplexed connection features (OpenSSH ControlPath/ControlMaster/ControlPersist).