Turn off react-hooks/preserve-manual-memoization ESLint rule#59134
Merged
Turn off react-hooks/preserve-manual-memoization ESLint rule#59134
Conversation
ravicious
added
the
no-changelog
nicholasmarais1158
approved these changes
Sep 15, 2025
avatus
approved these changes
Sep 15, 2025
public-teleport-github-review-bot
bot
removed the request for review
from ryanclark
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This rule is noisy, its message does not explain how to address the issue and in the release candidate version it seems to report some false positives. Turn it back on once those concerns are addressed. There's at least one instance where the warnings from this rule were noisy enough that they made it harder to spot a warning from react-hooks/exhaustive-deps (#58971 (comment)).
Related issues:
useMemos facebook/react#34289