fix: Add SSO MFA support to headless login 🐛 #59051
Merged
Conversation
Signed-off-by: Chris Thach <chris.thach@goteleport.com>
cthach
added
backport-required
mfa
cthach
commented
Sep 11, 2025
Joerger
approved these changes
Sep 12, 2025
Comment on lines
+116
to
+119
| shouldShowMfaPrompt(mfa) ? ( | ||
| <AuthnDialog mfaState={mfa} /> | ||
| ) : ( | ||
| <HeadlessRequestDialog |
Contributor
There was a problem hiding this comment.
Nice! You made this much simpler than I thought it would be.
Contributor
|
No need to backport to v16, SSO MFA was added in v17. I removed the tag for you. |
avatus
approved these changes
Sep 12, 2025
public-teleport-github-review-bot
bot
removed the request for review
from alexhemard
Contributor
This was referenced Sep 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Fixes #58757 && #58984
Changelog: Fixed headless login so that it supports both WebAuthn and SSO for MFA
The
HeadlessRequestcomponent now uses the standardized MFA prompt (useMfastate func andAuthnDialogcomponent) which supports WebAuthn and SSO MFA.Why?
The headless login component always assumed WebAuthn as the primary MFA method. This change makes it so that the user can now choose their preferred method for providing an addition auth factor instead of assuming WebAuthn.
Browser Tests
Test results from manually exercising headless login with the fix:
Demo
This demo shows: