fix: enhance multi-resource editing in tctl edit#58878
Merged
Conversation
This PR enhances tctl edit command to support multiple resources such as when editing all roles. `tctl edit roles` Now, all updated roles are reflected into the backend and not only the first one. Signed-off-by: Tiago Silva <tiago.silva@goteleport.com>
tigrato
force-pushed
the
tigrato/tctleditmulti
branch
from
823d3fc to
5523632
Compare
zmb3
approved these changes
Sep 8, 2025
| } | ||
|
|
||
| key := func(r services.UnknownResource) string { | ||
| return fmt.Sprintf("%s/%s", r.Kind, r.GetName()) |
Collaborator
There was a problem hiding this comment.
Don't we have a func in the backend package for this? (Instead of using sprintf)
Contributor
Author
There was a problem hiding this comment.
it’s not specifically meant for the backend since the data doesn’t really depend on that. In fact, it should only support a single Kind - from what I remember all collections only support a single kind. I left it as is just in case someone starts using multiple kinds and the names collide
avatus
approved these changes
Sep 8, 2025
public-teleport-github-review-bot
bot
removed the request for review
from capnspacehook
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Contributor
This was referenced Sep 8, 2025
mmcallister
pushed a commit
that referenced
this pull request
Sep 22, 2025
* fix: enhance multi-resource editing in tctl edit This PR enhances tctl edit command to support multiple resources such as when editing all roles. `tctl edit roles` Now, all updated roles are reflected into the backend and not only the first one. Signed-off-by: Tiago Silva <tiago.silva@goteleport.com> * add multi int tests --------- Signed-off-by: Tiago Silva <tiago.silva@goteleport.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR enhances tctl edit command to support multiple resources such as when editing all roles.
tctl edit rolesNow, all updated roles are reflected into the backend and not only the first one.
Changelog: Support multiple resource editing in
tctl editwhen editing collectionsFixes #38531