Merged
Conversation
github-actions
bot
requested review from
danielashare,
gabrielcorado,
greedy52 and
probakowski
github-actions
bot
added
audit-log
tigrato
force-pushed
the
tigrato/session-end-users
branch
from
a1a17c0 to
3831fdb
Compare
danielashare
approved these changes
Sep 8, 2025
tigrato
changed the title
probakowski
approved these changes
Sep 8, 2025
public-teleport-github-review-bot
bot
removed request for
gabrielcorado,
greedy52 and
zmb3
Similarly to #58853, session's end events also showed inconsistencies in participant fiedls for different protocols. This created an issue where root users couldn't watch session recordings they participated depending on the protocol, while some local users could. Since ithe session's participants field is a repeated string, we can't apply the same logic as in #58853, so we need to transform the username prior to emitting the session end events. This will allow leaf users to see their recordings. Fixes #12324 Fixes teleport-private#166 Signed-off-by: Tiago Silva <tiago.silva@goteleport.com>
tigrato
force-pushed
the
tigrato/session-end-users
branch
from
3831fdb to
ad79b39
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Contributor
mmcallister
pushed a commit
that referenced
this pull request
Sep 22, 2025
Similarly to #58853, session's end events also showed inconsistencies in participant fiedls for different protocols. This created an issue where root users couldn't watch session recordings they participated depending on the protocol, while some local users could. Since ithe session's participants field is a repeated string, we can't apply the same logic as in #58853, so we need to transform the username prior to emitting the session end events. This will allow leaf users to see their recordings. Fixes #12324 Fixes teleport-private#166 Signed-off-by: Tiago Silva <tiago.silva@goteleport.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similarly to #58853, session's end events also showed inconsistencies in participant fiedls for different protocols.
This created an issue where root users couldn't watch session recordings they participated depending on the protocol, while some local users could.
Since ithe session's participants field is a repeated string, we can't apply the same logic as in #58853, so we need to transform the username prior to emitting the session end events. This will allow leaf users to see their recordings.
Fixes #12324
Fixes gravitational/teleport-private#166
Changelog: Fixed a bug that prevented root users from viewing session recordings when they were participants.