Conversation
cthach
added
backport-required
go
cthach
commented
Sep 5, 2025
Signed-off-by: Chris Thach <chris.thach@goteleport.com>
cthach
force-pushed
the
cthach/bump-go
branch
from
8bbd14e to
15bd825
Compare
rosstimothy
reviewed
Sep 5, 2025
Signed-off-by: Chris Thach <chris.thach@goteleport.com>
Signed-off-by: Chris Thach <chris.thach@goteleport.com>
Signed-off-by: Chris Thach <chris.thach@goteleport.com>
Signed-off-by: Chris Thach <chris.thach@goteleport.com>
cthach
commented
Sep 5, 2025
Contributor
Author
There was a problem hiding this comment.
Changes to this files were necessary to make the linter happy
Contributor
There was a problem hiding this comment.
Changes are fine as is, you could also have used trace.BadParameter("%s", tc.msg) to appease the linter.
rosstimothy
approved these changes
Sep 5, 2025
Contributor
There was a problem hiding this comment.
Changes are fine as is, you could also have used trace.BadParameter("%s", tc.msg) to appease the linter.
cthach
requested review from
camscale,
doggydogworld,
fheinecke,
hugoShaka,
r0mant,
russjones,
strideynet,
tigrato and
zmb3
as code owners
tigrato
approved these changes
Sep 5, 2025
public-teleport-github-review-bot
bot
removed the request for review
from bernardjkim
Contributor
cthach
added a commit
that referenced
this pull request
Sep 5, 2025
* chore: Bump Go to 1.24.7 Signed-off-by: Chris Thach <chris.thach@goteleport.com> * refactor: remove toolchain directive Signed-off-by: Chris Thach <chris.thach@goteleport.com> * fix: revert aws go.mod Signed-off-by: Chris Thach <chris.thach@goteleport.com> * chore: update Go version to 1.24.7 for terraform-mwi Signed-off-by: Chris Thach <chris.thach@goteleport.com> * fix: Go lint issues Signed-off-by: Chris Thach <chris.thach@goteleport.com> --------- Signed-off-by: Chris Thach <chris.thach@goteleport.com>
cthach
added a commit
that referenced
this pull request
Sep 5, 2025
* chore: Bump Go to 1.24.7 Signed-off-by: Chris Thach <chris.thach@goteleport.com> * refactor: remove toolchain directive Signed-off-by: Chris Thach <chris.thach@goteleport.com> * fix: revert aws go.mod Signed-off-by: Chris Thach <chris.thach@goteleport.com> * chore: update Go version to 1.24.7 for terraform-mwi Signed-off-by: Chris Thach <chris.thach@goteleport.com> * fix: Go lint issues Signed-off-by: Chris Thach <chris.thach@goteleport.com> --------- Signed-off-by: Chris Thach <chris.thach@goteleport.com>
cthach
added a commit
that referenced
this pull request
Sep 5, 2025
* chore: Bump Go to 1.24.7 Signed-off-by: Chris Thach <chris.thach@goteleport.com> * refactor: remove toolchain directive Signed-off-by: Chris Thach <chris.thach@goteleport.com> * fix: revert aws go.mod Signed-off-by: Chris Thach <chris.thach@goteleport.com> * chore: update Go version to 1.24.7 for terraform-mwi Signed-off-by: Chris Thach <chris.thach@goteleport.com> * fix: Go lint issues Signed-off-by: Chris Thach <chris.thach@goteleport.com> --------- Signed-off-by: Chris Thach <chris.thach@goteleport.com>
cthach
added a commit
that referenced
this pull request
Sep 5, 2025
* chore: Bump Go to 1.24.7 Signed-off-by: Chris Thach <chris.thach@goteleport.com> * refactor: remove toolchain directive Signed-off-by: Chris Thach <chris.thach@goteleport.com> * fix: revert aws go.mod Signed-off-by: Chris Thach <chris.thach@goteleport.com> * chore: update Go version to 1.24.7 for terraform-mwi Signed-off-by: Chris Thach <chris.thach@goteleport.com> * fix: Go lint issues Signed-off-by: Chris Thach <chris.thach@goteleport.com> --------- Signed-off-by: Chris Thach <chris.thach@goteleport.com>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 6, 2025
* chore: Bump Go to 1.24.7 ⬆️ (#58806) * chore: Bump Go to 1.24.7 Signed-off-by: Chris Thach <chris.thach@goteleport.com> * refactor: remove toolchain directive Signed-off-by: Chris Thach <chris.thach@goteleport.com> * fix: revert aws go.mod Signed-off-by: Chris Thach <chris.thach@goteleport.com> * chore: update Go version to 1.24.7 for terraform-mwi Signed-off-by: Chris Thach <chris.thach@goteleport.com> * fix: Go lint issues Signed-off-by: Chris Thach <chris.thach@goteleport.com> --------- Signed-off-by: Chris Thach <chris.thach@goteleport.com> * Do not update api/go.mod to preserve stability Signed-off-by: Chris Thach <chris.thach@goteleport.com> --------- Signed-off-by: Chris Thach <chris.thach@goteleport.com>
mmcallister
pushed a commit
that referenced
this pull request
Sep 22, 2025
* chore: Bump Go to 1.24.7 Signed-off-by: Chris Thach <chris.thach@goteleport.com> * refactor: remove toolchain directive Signed-off-by: Chris Thach <chris.thach@goteleport.com> * fix: revert aws go.mod Signed-off-by: Chris Thach <chris.thach@goteleport.com> * chore: update Go version to 1.24.7 for terraform-mwi Signed-off-by: Chris Thach <chris.thach@goteleport.com> * fix: Go lint issues Signed-off-by: Chris Thach <chris.thach@goteleport.com> --------- Signed-off-by: Chris Thach <chris.thach@goteleport.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's that time again y'all 🧑🔧
Changelog: Updated Go to 1.24.7.
Will promote out of draft when CI and my local tests pass.They pass! 🕺