-
Notifications
You must be signed in to change notification settings - Fork 2k
Web UI: Integrations Enroll redesign #58421
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
552d37d
feat(Integrations): init redesign
alexhemard 4e4f2c4
mv to Integrations/Enroll/Shared
alexhemard f056484
add missing license
alexhemard ef9baf7
feedback, search tile descriptions
alexhemard 57d2fcf
fix storybook
alexhemard 32eb75a
fix missing border for disabled tile hover
alexhemard fd4a2d8
replace useUrlFiltering, feedback
alexhemard f199bea
remove bot name filter hack
alexhemard 2860255
simplify useIntegrationPickerState hook
alexhemard d5bab33
remove unused fns, tests
alexhemard 62d4c7b
renderBadge -> Badge
alexhemard 36fc5eb
feedback
alexhemard 130b713
update RolesAnywhere
alexhemard b82a52c
feedback
alexhemard 991935a
filter tags if no matching integrations
alexhemard d5a557d
update comments
alexhemard File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. i think there are unused components and or functions in this file, can you double check? i would put a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
with this change, the
botnav section on click doesn't get highlighted like in the bottom imagebefore your changes:
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kimlisa Should this have a link out icon since it redirects to the Integrations page?
Existing shortcut
Proposed