Forcibly exit VNet admin process if network stack doesn't shut down after timeout#58298
Merged
Forcibly exit VNet admin process if network stack doesn't shut down after timeout#58298
Conversation
ravicious
approved these changes
Aug 26, 2025
Member
ravicious
left a comment
ravicious
left a comment
There was a problem hiding this comment.
I tested this by adding yet another goroutine to the errgroup that hangs forever and the code does its job. I tried it using an actual VNet daemon in a VM.
ravicious
reviewed
Aug 26, 2025
Member
There was a problem hiding this comment.
@nklaassen Do you happen to know why the wireguard package isn't getting updated? I'm not familiar with our upgrade process for Go packages, but I see that we're on an old version. In May there were multiple commits in the device package that could be related to deadlocks. https://git.zx2c4.com/wireguard-go/log/
Lines 242 to 243 in 387e4ef
nklaassen
approved these changes
Aug 26, 2025
Contributor
This was referenced Aug 27, 2025
Merged
mmcallister
pushed a commit
that referenced
this pull request
Sep 22, 2025
…fter timeout (#58298) * Forcibly exit VNet admin process if network stack doesn't shut down after timeout * Add better logging * Review comments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #56834
I tried to reproduce the issue, but unfortunately with no luck.
I implemented the proposed solution: better logging and forcibly exiting the admin process after a timeout.
changelog: Fixed an issue where VNet could not start because of "VNet is already running" error