Set MaxAge in web cookie if time until expiry is > 0#58293
Merged
Conversation
This updates the logic to only setting max-age if the provided expiry is in the future rather than any non-zero value.
avatus
added
the
no-changelog
zmb3
approved these changes
Aug 24, 2025
rosstimothy
approved these changes
Aug 24, 2025
public-teleport-github-review-bot
bot
removed request for
kimlisa and
ryanclark
mmcallister
pushed a commit
that referenced
this pull request
Sep 22, 2025
This updates the logic to only setting max-age if the provided expiry is in the future rather than any non-zero value.
avatus
added a commit
that referenced
this pull request
Nov 6, 2025
This updates the logic to only setting max-age if the provided expiry is in the future rather than any non-zero value.
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 10, 2025
* Set MaxAge for cookie based on WebSession expiry (#58091) * Set MaxAge in web cookie if time until expiry is > 0 (#58293) This updates the logic to only setting max-age if the provided expiry is in the future rather than any non-zero value. * Respect WebIdleTimeout in bearerTokenTTL (#59645) The webUI will log a user out due to invalid token if they haven't pinged the server within the idle time, which defaulted to the bearer token default (10 minutes). Instead, we will only default to 10 minutes if the web_idle_timeout is not configured in the cluster config
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates the logic to only setting max-age if the provided expiry is in the future rather than any non-zero value. this fixes the failing tests in
edue to atime.Now()being in the past (non-zero)