OIDC: Enable Separate 'Request Object Mode' For MFA Flow#58177
Merged
rhammonds-teleport merged 3 commits intomasterfrom Aug 22, 2025
Merged
OIDC: Enable Separate 'Request Object Mode' For MFA Flow#58177rhammonds-teleport merged 3 commits intomasterfrom
rhammonds-teleport merged 3 commits intomasterfrom
Conversation
rhammonds-teleport
temporarily deployed
to
docs-amplify
GitHub Actions
Inactive
github-actions
bot
requested review from
bernardjkim,
hugoShaka,
marcoandredinis,
mmcallister,
ptgott,
r0mant and
tigrato
Contributor
|
Amplify deployment status
|
rhammonds-teleport
temporarily deployed
to
docs-amplify
GitHub Actions
Inactive
zmb3
approved these changes
Aug 20, 2025
| // RequestObjectMode determines how JWT-Secured Authorization Requests will be used for authorization | ||
| // requests. JARs, or request objects, can provide integrity protection, source authentication, and confidentiality | ||
| // for authorization request parameters. | ||
| string RequestObjectMode = 7 [(gogoproto.jsontag) = "request_object_mode,omitempty"]; |
Collaborator
There was a problem hiding this comment.
Should we mention right here that we default to the connector property of the same name if not explicitly set?
Contributor
Author
There was a problem hiding this comment.
Good idea.
rhammonds-teleport
temporarily deployed
to
docs-amplify
GitHub Actions
Inactive
added 3 commits
August 21, 2025 22:32
…cally for MFA. If 'request_object_mode' is omitted from MFA settings, then the base connector's configuration it used for both login and MFA flows.
…Settings.RequestObjectMode' if omitted.
rhammonds-teleport
force-pushed
the
rhammonds/split-mfa-jar-settings
branch
from
9c27dc6 to
784c78a
Compare
rhammonds-teleport
temporarily deployed
to
docs-amplify
GitHub Actions
Inactive
Joerger
approved these changes
Aug 22, 2025
public-teleport-github-review-bot
bot
removed request for
bernardjkim,
hugoShaka,
mmcallister,
ptgott and
r0mant
public-teleport-github-review-bot
bot
removed the request for review
from tigrato
tigrato
approved these changes
Aug 22, 2025
Contributor
|
@rhammonds-teleport See the table below for backport results.
|
rhammonds-teleport
added a commit
that referenced
this pull request
Aug 22, 2025
* OIDC: Allow users to specify a separate 'request_object_mode' specifically for MFA. If 'request_object_mode' is omitted from MFA settings, then the base connector's configuration it used for both login and MFA flows. * gen crds * Add a word of caution about the default behavior of 'OIDCConnectorMFASettings.RequestObjectMode' if omitted. --------- Co-authored-by: Ryan Hammonds <ryan.hammonds@Ryans-MacBook-Pro.local>
rhammonds-teleport
added a commit
that referenced
this pull request
Aug 22, 2025
rhammonds-teleport
added a commit
that referenced
this pull request
Aug 22, 2025
This was referenced Aug 22, 2025
mmcallister
pushed a commit
that referenced
this pull request
Sep 22, 2025
* OIDC: Allow users to specify a separate 'request_object_mode' specifically for MFA. If 'request_object_mode' is omitted from MFA settings, then the base connector's configuration it used for both login and MFA flows. * gen crds * Add a word of caution about the default behavior of 'OIDCConnectorMFASettings.RequestObjectMode' if omitted. --------- Co-authored-by: Ryan Hammonds <ryan.hammonds@Ryans-MacBook-Pro.local>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We recently enabled JWT-Secured Authorization Requests for OIDC connectors with #56990, but made the faulty assumption that users would want to use the same request object mode for both login and MFA flows. This PR corrects that oversight by enabling a separate setting for each flow.
If
request_object_modeis omitted from the MFA settings then the base connector's configuration is used for both modes. Ex:vs
Changelog: Enable separate
request_object_modesetting for MFA flow in OIDC connectors.