Fix uncaught exception caused by tsh daemon stop when TELEPORT_TOOLS_VERSION is set#58125
Merged
Fix uncaught exception caused by tsh daemon stop when TELEPORT_TOOLS_VERSION is set#58125
tsh daemon stop when TELEPORT_TOOLS_VERSION is set#58125Conversation
ravicious
approved these changes
Aug 20, 2025
rosstimothy
approved these changes
Aug 20, 2025
public-teleport-github-review-bot
bot
removed the request for review
from bl-nero
gzdunek
changed the title
tsh daemon stop when TELEPORT_TOOLS_VERSION is settsh daemon stop when TELEPORT_TOOLS_VERSION is set
Contributor
This was referenced Aug 20, 2025
Merged
Merged
rhammonds-teleport
pushed a commit
that referenced
this pull request
Aug 20, 2025
…OOLS_VERSION` is set (#58125) * Avoid losing `this` when calling `logger.error` * Disable tsh autoupdates in `tsh daemon stop`
ryanclark
pushed a commit
that referenced
this pull request
Aug 20, 2025
…OOLS_VERSION` is set (#58125) * Avoid losing `this` when calling `logger.error` * Disable tsh autoupdates in `tsh daemon stop`
mmcallister
pushed a commit
that referenced
this pull request
Sep 22, 2025
…OOLS_VERSION` is set (#58125) * Avoid losing `this` when calling `logger.error` * Disable tsh autoupdates in `tsh daemon stop`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When closing Connect on Windows, I saw the following message:
This happened because a class method was passed without binding, causing
thisto be lost.(Before #56683 this could only log an error, but now it shows this alert.)
After I fixed that, I saw this in logs:
[20-08-25 16:08:33] [Daemon stop] error: 2025/08/20 16:08:33 ERROR Failed to update tools version error="archive file is not found: 404" version=19.0.0-dev.gzdunek.13Turns out that we forgot to disable tsh autoupdates for
tsh daemon stop. I hadTELEPORT_TOOLS_VERSIONset globally and it was read by tsh.changelog: Fixed an uncaught exception in Teleport Connect on Windows when closing the app while the
TELEPORT_TOOLS_VERSIONenvironment variable is set