[AWSIC] Adds RoleSyncMode selection to tctl plugins tooling#58046
Merged
[AWSIC] Adds RoleSyncMode selection to tctl plugins tooling#58046
tctl plugins tooling#58046Conversation
r0mant
requested review from
kopiczko and
smallinsky
and removed request for
gzdunek and
kimlisa
r0mant
reviewed
Aug 19, 2025
Collaborator
There was a problem hiding this comment.
Changelog: Added RolesSyncMode selection to tctl AWSIC plugin installer
@tcsc Also, this changelog entry will not make sense to anyone outside of IG team and certainly not users reading this who are the primary consumers of the changelog. Can you rephrase it to be more human readable?
tcsc
changed the title
tctl plugins install awsictctl plugins tooling
Contributor
Author
|
Accompanying documentation is in #58345 |
r0mant
approved these changes
Aug 26, 2025
Collaborator
r0mant
left a comment
r0mant
left a comment
There was a problem hiding this comment.
lgtm with some wording suggestions
smallinsky
approved these changes
Aug 26, 2025
public-teleport-github-review-bot
bot
removed the request for review
from kopiczko
tcsc
commented
Aug 28, 2025
Allows the user to specify a RolesSyncMode on the command line when installing or editing the Identity Center integration. Also prevents the user from specifying group import filters when rolesSyncMode == NONE, because allowing them will make an invalid plugin configuration.
tcsc
force-pushed
the
tcsc/tctl-set-role-sync-mode
branch
from
2b9f4f1 to
a1dec18
Compare
Contributor
cthach
pushed a commit
that referenced
this pull request
Sep 4, 2025
…58046) Allows the user to specify a RolesSyncMode on the command line when installing or editing the Identity Center integration. Also prevents the user from specifying group import filters when rolesSyncMode == NONE, because allowing them will make an invalid plugin configuration.
Collaborator
|
@tcsc Was this backported? |
mmcallister
pushed a commit
that referenced
this pull request
Sep 22, 2025
…58046) Allows the user to specify a RolesSyncMode on the command line when installing or editing the Identity Center integration. Also prevents the user from specifying group import filters when rolesSyncMode == NONE, because allowing them will make an invalid plugin configuration.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows the user to specify a RolesSyncMode on the command line when installing or editing the
Identity Center integration.
Also prevents the user from specifying group import filters on installation when
roleSyncMode == NONE, because allowing them will make an invalid plugin configuration.Changelog: Added ability for user to select whether IC integration creates roles for all possible Account Assignments