Merged
Conversation
github-actions
bot
requested review from
hugoShaka,
marcoandredinis,
mmcallister,
ptgott,
r0mant,
tigrato and
zmb3
Contributor
|
Amplify deployment status
|
strideynet
reviewed
Aug 18, 2025
Contributor
strideynet
left a comment
strideynet
left a comment
There was a problem hiding this comment.
First pass - looks pretty good, just need a little more time to dive into it.
strideynet
approved these changes
Aug 19, 2025
tigrato
approved these changes
Aug 19, 2025
public-teleport-github-review-bot
bot
removed request for
hugoShaka,
marcoandredinis,
mmcallister,
ptgott,
r0mant,
timothyb89 and
zmb3
boxofrad
added a commit
that referenced
this pull request
Aug 21, 2025
Backport #58000 to branch/v18. changelog: MWI: `tbot` now supports managing Argo CD clusters via the `kubernetes/argo-cd` output service
boxofrad
added a commit
that referenced
this pull request
Sep 1, 2025
Backport #58000 to branch/v17 changelog: MWI: `tbot` now supports managing Argo CD clusters via the `kubernetes/argo-cd` output service
boxofrad
added a commit
that referenced
this pull request
Sep 3, 2025
Backport #58000 to branch/v17 changelog: MWI: `tbot` now supports managing Argo CD clusters via the `kubernetes/argo-cd` output service
mmcallister
pushed a commit
that referenced
this pull request
Sep 22, 2025
* K8S client supports `Apply` operations now * MWI: Add `kubernetes/argo-cd` service type * Add argocd to the tbot Helm chart * Fix broken service builder calls in terraform integration * Fix linting errors * Make test assertions easier to read * Use `t.Context` in test helper * Support for user-defined secret annotations
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the new Argo CD output type to
tbotdescribed in RFD 220.Closes #41459 and #43403.
changelog: MWI:
tbotnow supports managing Argo CD clusters via thekubernetes/argo-cdoutput service