Merged
Conversation
alexhemard
added
regression
size/sm
no-changelog
kimlisa
reviewed
Aug 14, 2025
Contributor
kimlisa
left a comment
kimlisa
left a comment
There was a problem hiding this comment.
can we try to keep the original intent? which was to send customizable size instead of hard coding it?
nicholasmarais1158
approved these changes
Aug 21, 2025
Contributor
nicholasmarais1158
left a comment
nicholasmarais1158
left a comment
There was a problem hiding this comment.
Thanks for finding and fixing this. 🙏
I might have gone with changing the prop to $size, but that requires updating its usages. This looks good to me. 👍
kimlisa
approved these changes
Aug 21, 2025
public-teleport-github-review-bot
bot
removed request for
flyinghermit and
ravicious
alexhemard
force-pushed
the
alexhemard/bug/fix-integration-icon-size
branch
from
5f5c13b to
d0668fa
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Contributor
|
@alexhemard See the table below for backport results.
|
This was referenced Aug 21, 2025
mmcallister
pushed a commit
that referenced
this pull request
Sep 22, 2025
* bug(Integrations): fix icon size * don't forward size prop * cleanup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Icons on the integration page were appearing teeny tiny for some tiles. Possibly a regression from #57563 which added a
sizeprop to theResourceIconcomponent.Fix
Updated the icon css to match other tiles (Bots)
before
after