Merged
Conversation
ravicious
reviewed
Aug 13, 2025
danielashare
force-pushed
the
danielashare/unstick-keys
branch
3 times, most recently
from
a81aea1 to
636f4da
Compare
ravicious
approved these changes
Aug 14, 2025
Member
ravicious
left a comment
ravicious
left a comment
There was a problem hiding this comment.
Yup, it works correctly now!
danielashare
force-pushed
the
danielashare/unstick-keys
branch
from
636f4da to
c32dc35
Compare
danielashare
force-pushed
the
danielashare/unstick-keys
branch
from
c32dc35 to
77599b1
Compare
kiosion
approved these changes
Aug 19, 2025
Contributor
|
@danielashare See the table below for backport results.
|
This was referenced Aug 20, 2025
mmcallister
pushed a commit
that referenced
this pull request
Sep 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We're seeing issues where keys are getting stuck on remote desktop sessions when users use host OS shortcuts, most commonly Cmd+Shift+[3|4|5] to take a screenshot on MacOS. This is happening because when MacOS takes focus away from the browser, it doesn't send any key up events. The browser also doesn't detect focus out or blur events.
To fix this, I track the remote state of modifier keys in the
InputHandler. When a key is pressed, the local modifiers are compared to the remote modifiers. If there's a difference in state, the remote modifiers are updated before sending the original key.Closes: #54725, #53075
changelog: Prevent modifier keys from getting stuck during remote desktop sessions