Add TELEPORT_UNSTABLE_GRPC_RECV_SIZE env var option#57846
Merged
Conversation
Contributor
Author
|
Can reproduce the failure by setting the size to be too small intentionally: % TELEPORT_UNSTABLE_GRPC_RECV_SIZE=4000 ./build/tctl get all
ERROR: grpc: received message larger than max (8715 vs. 4000) |
okraport
force-pushed
the
okraport/grpc-msg-size-overwrite
branch
from
c30b76d to
a00f408
Compare
rosstimothy
reviewed
Aug 13, 2025
Comment on lines
+29
to
+32
| // parseBytes takes human represtation of bytes such as '24mb' and returns number of bytes as an integer | ||
| // | ||
| // Only support a subset of SI prefixes up to gi/gb. | ||
| func parseBytes(s string) (int, error) { |
Contributor
There was a problem hiding this comment.
This is nice, but might be more complicated than we need. What do you think about requiring the value to always be specified in bytes? Would that UX be too suboptimal?
Contributor
Author
There was a problem hiding this comment.
My thinking here was that the minimum being 4mib any client side error will want to set that value much higher and personally I prefer the readable variant:
TELEPORT_UNSTABLE_GRPC_RECV_SIZE=16mib tctl get all
# vs
TELEPORT_UNSTABLE_GRPC_RECV_SIZE=16777216 tctl get all
That being said if we are doing this it's already a workaround I'm happy to remove it if it's too overkill!
rosstimothy
approved these changes
Aug 14, 2025
tigrato
reviewed
Aug 14, 2025
tigrato
approved these changes
Aug 19, 2025
Setting this env var allows overwriting the max size of a grpc message the client can recieve (default is 4MB). Towards: gravitational/teleport.e#6759 changelog: Add TELEPORT_UNSTABLE_GRPC_RECV_SIZE env var which can be set to overwrite client side max grpc message size.
okraport
force-pushed
the
okraport/grpc-msg-size-overwrite
branch
from
07c804c to
4550102
Compare
Contributor
This was referenced Aug 19, 2025
ryanclark
pushed a commit
that referenced
this pull request
Aug 19, 2025
Setting this env var allows overwriting the max size of a grpc message the client can recieve (default is 4MB). Towards: gravitational/teleport.e#6759 changelog: Add TELEPORT_UNSTABLE_GRPC_RECV_SIZE env var which can be set to overwrite client side max grpc message size.
ryanclark
pushed a commit
that referenced
this pull request
Aug 19, 2025
Setting this env var allows overwriting the max size of a grpc message the client can recieve (default is 4MB). Towards: gravitational/teleport.e#6759 changelog: Add TELEPORT_UNSTABLE_GRPC_RECV_SIZE env var which can be set to overwrite client side max grpc message size.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Setting this env var allows overwriting the max
size of a grpc message the client can receive (default is 4MB).
Towards: https://github.com/gravitational/teleport.e/issues/6759
changelog: Add TELEPORT_UNSTABLE_GRPC_RECV_SIZE env var which can be set to overwrite client side max grpc message size.