Skip to content

[v18] Fix Teleport Connect connecting to WDS v17 and earlier #57842

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danielashare merged 1 commit into from
Aug 15, 2025
Merged

[v18] Fix Teleport Connect connecting to WDS v17 and earlier #57842

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion web/packages/shared/libs/tdp/client.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,7 +187,12 @@ export class TdpClient extends EventEmitter<EventMap> {
this.sendClientScreenSpec(options.screenSpec);
}

if (options.keyboardLayout !== undefined) {
// 0 represents the default keyboard layout from the point of view of the
// remote desktop, so there is no need to send this message. Additionally,
// for clients (Connect) that don't support specifying a keyboard layout
// and WDS versions that don't support this feature (v17 and earlier), this
// avoids the connection crashing.
if (options.keyboardLayout !== undefined && options.keyboardLayout !== 0) {
this.sendClientKeyboardLayout(options.keyboardLayout);
}

Expand Down
Loading