Skip to content

Ignore older updated versions of CTMU after switching to a version with multi-cluster support#57785

Merged
vapopov merged 1 commit intomasterfrom
vapopov/cmtu-fix-previous-version-re-execution
Aug 13, 2025
Merged

Ignore older updated versions of CTMU after switching to a version with multi-cluster support#57785
vapopov merged 1 commit intomasterfrom
vapopov/cmtu-fix-previous-version-re-execution

Conversation

@vapopov
Copy link
Copy Markdown
Contributor

@vapopov vapopov commented Aug 11, 2025

In this PR add fix to ignore existing updated version by v1 client tools managed updates, steps to reproduce:

# Install tsh with v1 CTMU (17.5.4)
$ teleport17.5.4/tsh version
Teleport v17.5.4 git:v17.5.4-0-g0fa760c go1.23.10

# Manually upgrade tsh to v17.6.0 with v2 CTMU, since it is updated by v1 CTMU `~/.tsh/bin/tsh` 
# is going to be created with requested version
$ TELEPORT_TOOLS_VERSION=17.6.0 teleport17.5.4/tsh version
Teleport v17.6.0 git:v17.6.0-0-g4c3b13b go1.23.11
Re-executed from version: 17.5.4

# Upgrade manually installed version of tsh to version 17.7.1
$ teleport17.7.1/tsh version
Teleport v17.6.0 git:v17.6.0-0-g4c3b13b go1.23.11
Re-executed from version: 17.7.1

# A manually upgraded version now always re-executes `~/.tsh/bin/tsh` and logs in to the cluster
# if the required version is the same as the installed version, it is now ignored.
$ teleport17.7.1/tsh login --proxy proxy.example.com
$ teleport17.7.1/tsh version
Teleport v17.6.0 git:v17.6.0-0-g4c3b13b go1.23.11
Re-executed from version: 17.7.1

changelog: Fixed the case where the auto-updated client tools did not use the intended version.

Copy link
Copy Markdown
Contributor

@Tener Tener left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change itself looks good to me. I think we could make the changelog entry easier to understand, given it is meant to be client-facing. So instead of:

changelog: Fix re-execution of a previously updated version of client tools managed updates for the new version multi-cluster support

Perhaps something like this?

changelog: Fixed the case where the auto-updated client tools did not use the intended version.

@public-teleport-github-review-bot public-teleport-github-review-bot bot removed the request for review from hugoShaka August 12, 2025 10:20
@vapopov vapopov added this pull request to the merge queue Aug 13, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 13, 2025
@vapopov vapopov added this pull request to the merge queue Aug 13, 2025
Merged via the queue into master with commit ba13807 Aug 13, 2025
47 checks passed
@vapopov vapopov deleted the vapopov/cmtu-fix-previous-version-re-execution branch August 13, 2025 20:16
@backport-bot-workflows
Copy link
Copy Markdown
Contributor

@vapopov See the table below for backport results.

Branch Result
branch/v16 Create PR
branch/v17 Create PR
branch/v18 Create PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants