[v18] Fix kube port-forward race with multiple ports#57736
Merged
rana merged 1 commit intobranch/v18from Aug 11, 2025
Merged
Conversation
Fixes a race condition when forwarding multiple ports to a single pod. Root cause was concurrent access to an unguarded `auditSent` map in the forwarder `portForward()` function. Changes: `lib/kube/proxy/forwarder.go` - Added mutex for `auditSent` map in `portForward()` `lib/kube/proxy/portforward_test.go` - Added mock test for Kubernetes forwarding multiple ports `lib/kube/proxy/testing/kube_server/kube_mock.go` - Revised mock server `portforward` function to process each stream in a goroutine `lib/kube/proxy/utils_test.go` - Updated test context `startKubeServices` function to allow and expect `net.ErrClosed` Fixes #57242
creack
approved these changes
Aug 9, 2025
tigrato
approved these changes
Aug 11, 2025
tigrato
approved these changes
Aug 11, 2025
public-teleport-github-review-bot
bot
removed request for
fspmarshall and
rosstimothy
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport #57474 to branch/v18
changelog: Kubernetes Access: Fixed a bug when forwarding multiple ports to a single pod