[v18] Add new oidc subtype for Kubernetes joining (#57538)#57683
Merged
timothyb89 merged 1 commit intobranch/v18from Aug 8, 2025
Merged
[v18] Add new oidc subtype for Kubernetes joining (#57538)#57683timothyb89 merged 1 commit intobranch/v18from
oidc subtype for Kubernetes joining (#57538)#57683timothyb89 merged 1 commit intobranch/v18from
Conversation
* MWI: Add `oidc` subtype for Kubernetes joining This adds a new `oidc` subtype for Kubernetes joining, which allows workloads to join using a Kubernetes service account token (JWT) as usual, but verifies it using an OIDC flow rather than a static JWKS keyset. This should better support platforms like EKS where the JWKS keyset is rotated regularly. * Validate OIDC subtype properly * Initialize OIDC validator at startup * Fix OIDC claims implementation * Force use of cluster name as audience * Remove authorized party workaround * Reintroduce kubernetes claims check * Remove unused constant * Update generated operator resources * Update generated TF docs * Add validator tests * Improve proto docs, enforce HTTP issuers, and add insecure override * Update autogenerated docs
Contributor
|
Amplify deployment status
|
hugoShaka
approved these changes
Aug 8, 2025
zmb3
approved these changes
Aug 8, 2025
timothyb89
added a commit
that referenced
this pull request
Aug 12, 2025
* MWI: Add `oidc` subtype for Kubernetes joining This adds a new `oidc` subtype for Kubernetes joining, which allows workloads to join using a Kubernetes service account token (JWT) as usual, but verifies it using an OIDC flow rather than a static JWKS keyset. This should better support platforms like EKS where the JWKS keyset is rotated regularly. * Validate OIDC subtype properly * Initialize OIDC validator at startup * Fix OIDC claims implementation * Force use of cluster name as audience * Remove authorized party workaround * Reintroduce kubernetes claims check * Remove unused constant * Update generated operator resources * Update generated TF docs * Add validator tests * Improve proto docs, enforce HTTP issuers, and add insecure override * Update autogenerated docs
Merged
github-merge-queue bot
pushed a commit
that referenced
this pull request
Aug 22, 2025
* [v18] Add new `oidc` subtype for Kubernetes joining (#57538) (#57683) * MWI: Add `oidc` subtype for Kubernetes joining This adds a new `oidc` subtype for Kubernetes joining, which allows workloads to join using a Kubernetes service account token (JWT) as usual, but verifies it using an OIDC flow rather than a static JWKS keyset. This should better support platforms like EKS where the JWKS keyset is rotated regularly. * Validate OIDC subtype properly * Initialize OIDC validator at startup * Fix OIDC claims implementation * Force use of cluster name as audience * Remove authorized party workaround * Reintroduce kubernetes claims check * Remove unused constant * Update generated operator resources * Update generated TF docs * Add validator tests * Improve proto docs, enforce HTTP issuers, and add insecure override * Update autogenerated docs * Partially backport OIDC changes to fix build, include #57789 This partially backports various dependencies of the original change. Note that this is not a clean backport, and minor code and organizational changes were made to facilitate this backport, including copying some OIDC code directly into the token validator. Additionally, caching support from #57789 was integrated directly. It inherently depends on the same OIDC code that required modification, so it has been pulled in directly. * Remove caching support from the backport I've abandoned the caching approach in #57789, so this PR will proceed without caching, as in branch/v18.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #57538 for branch/v18
changelog: Add new oidc joining mode for Kubernetes delegated joining to support providers that can be configured to provide public OIDC endpoints, like EKS, AKS, and GKE
oidcsubtype for Kubernetes joiningThis adds a new
oidcsubtype for Kubernetes joining, which allows workloads to join using a Kubernetes service account token (JWT) as usual, but verifies it using an OIDC flow rather than a static JWKS keyset. This should better support platforms like EKS where the JWKS keyset is rotated regularly.Validate OIDC subtype properly
Initialize OIDC validator at startup
Fix OIDC claims implementation
Force use of cluster name as audience
Remove authorized party workaround
Reintroduce kubernetes claims check
Remove unused constant
Update generated operator resources
Update generated TF docs
Add validator tests
Improve proto docs, enforce HTTP issuers, and add insecure override
Update autogenerated docs