Fix Alt+Click in desktop sessions#57637
Merged
danielashare merged 1 commit intomasterfrom Aug 11, 2025
Merged
Conversation
danielashare
force-pushed
the
danielashare/alt-click-fix
branch
from
87d0ce5 to
62abc42
Compare
ryanclark
approved these changes
Aug 7, 2025
gzdunek
approved these changes
Aug 8, 2025
danielashare
force-pushed
the
danielashare/alt-click-fix
branch
from
62abc42 to
7ac7b0c
Compare
danielashare
force-pushed
the
danielashare/alt-click-fix
branch
from
7ac7b0c to
a08d77e
Compare
Contributor
|
@danielashare See the table below for backport results.
|
This was referenced Aug 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #50725, where a user couldn't Alt+Click.
This was being blocked by the
Withholderclass that withholds theAltkey until another key is pressed to avoid stuck keys. To fix this issue, I modifiedWithholderto also handle mouse events so that when a click is registered it flushes any held keys to the remote desktop.Before:
Notice that after finish selecting each line and release
Alt, the VSCode menu items at the top left are underlined showing thatAltis only sent to the client after I release it.https://github.com/user-attachments/assets/873e31b8-07e5-4fde-8285-c9149c4cb384
After:
I start holding
Altafter selecting the first line, but it isn't sent to the remote desktop until I click on the second line. This shows thatWithholderlogic is maintained until another event comes in.https://github.com/user-attachments/assets/5fbd091f-044d-43a1-8867-bc046da09931
changelog: Fix Alt+Click not being registered in remote desktop sessions.