Install wasm32 target in MacOS workflow#57525
Merged
probakowski merged 1 commit intomasterfrom Aug 5, 2025
Merged
Conversation
probakowski
added
the
no-changelog
probakowski
requested review from
camscale,
doggydogworld,
fheinecke,
klizhentas,
r0mant,
rosstimothy,
russjones and
zmb3
as code owners
fheinecke
approved these changes
Aug 4, 2025
Contributor
fheinecke
left a comment
fheinecke
left a comment
There was a problem hiding this comment.
LGTM provided that it has been tested via a dev build
zmb3
reviewed
Aug 4, 2025
Comment on lines
70
to
71
| - name: Install wasm-pack | ||
| run: make ensure-wasm-deps |
Collaborator
There was a problem hiding this comment.
Do we want to keep this here for now and remove it later, or can it be removed now?
Contributor
Author
There was a problem hiding this comment.
We have to keep it for now, otherwise build will fail until #57304 is merged
zmb3
approved these changes
Aug 4, 2025
public-teleport-github-review-bot
bot
removed the request for review
from strideynet
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is preparation for changes in #57304