[v16] fix: Agent Forwarding - Windows System Agent and 1Password agent#57514
Merged
Joerger merged 3 commits intobranch/v16from Aug 5, 2025
Merged
[v16] fix: Agent Forwarding - Windows System Agent and 1Password agent#57514Joerger merged 3 commits intobranch/v16from
Joerger merged 3 commits intobranch/v16from
Conversation
) * Move lib/utils/agentconn to lib/sshagent. * Move system agent connection logic and logging to sshagent.DialSystemAgent; Update comments. * Retrieve a new system SSH agent connection for each agent forwarding channel request. * Add test. * Add type aliases to teleagent. * Remove unused function. * Revert import to fix go mod tidy error. * Fix flaky test. * Address comments. * Use context.After stop function; Fix unsafe wg.Wait call.
espadolini
approved these changes
Aug 5, 2025
rosstimothy
approved these changes
Aug 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport #57243 to branch/v16
changelog: Fix a bug on Windows where a forwarded SSH agent would become dysfunctional after a single connection using the agent.