Skip to content

[v18] Fix CRL backfill #57321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zmb3 merged 2 commits into from
Jul 30, 2025
Merged

[v18] Fix CRL backfill #57321

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e3c2388
Fix CRL backfill
probakowski Jul 30, 2025
a02eb10
Update lib/auth/init.go
probakowski Jul 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 12 additions & 3 deletions lib/auth/init.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -747,15 +747,24 @@ func initializeAuthority(ctx context.Context, asrv *Server, caID types.CertAuthI
}
certBytes, signer, err := asrv.keyStore.GetTLSCertAndSigner(ctx, ca)
if err != nil {
return nil, nil, trace.Wrap(err)
asrv.logger.WarnContext(ctx, "Couldn't get CA certificate", "ca_type", caID.Type, "error", err)
continue
}
cert, err := tlsca.ParseCertificatePEM(certBytes)
if err != nil {
return nil, nil, trace.Wrap(err)
asrv.logger.WarnContext(ctx, "Couldn't parse CA certificate", "ca_type", caID.Type, "error", err)
continue
}

if cert.KeyUsage&x509.KeyUsageCRLSign == 0 {
asrv.logger.WarnContext(ctx, "Certificate authority can't sign CRLs, some Active Directory integrations will require a CA rotation", "ca_type", caID.Type)
continue
}

crl, err := keystore.GenerateCRL(cert, signer)
if err != nil {
return nil, nil, trace.Wrap(err)
asrv.logger.WarnContext(ctx, "Failed to generate CRL", "ca_type", caID.Type, "error", err)
continue
}
kp.CRL = crl
updated = true
Expand Down
Loading