Skip to content

[tctl/top] Fix tctl top not parsing teleport config #57306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
okraport wants to merge 1 commit into from
Closed

[tctl/top] Fix tctl top not parsing teleport config #57306

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion tool/tctl/common/top/command.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,11 +94,18 @@ func (c *Command) newMetricsClient(ctx context.Context) (string, MetricsClient,
}

// TryRun attempts to run subcommands.
func (c *Command) TryRun(ctx context.Context, cmd string, _ commonclient.InitFunc) (match bool, err error) {
func (c *Command) TryRun(ctx context.Context, cmd string, clientFunc commonclient.InitFunc) (match bool, err error) {
if cmd != c.top.FullCommand() {
return false, nil
}

// Call clientFunc to init `c.config`
_, closeFn, err := clientFunc(ctx)
if err != nil {
return true, trace.Wrap(err)
}
closeFn(ctx)

addr, metricsClient, err := c.newMetricsClient(ctx)
if err != nil {
return true, trace.Wrap(err)
Expand Down
Loading