[tctl] Seperate config parsing from client init#57265
Closed
[tctl] Seperate config parsing from client init#57265
Conversation
okraport
added
no-changelog
This change moves the tctl configuration parsing to be done before running the selected command and not be part of client init. This means commands that do not need a client can access the config such as `tctl top` when using socket mode. Co-authored-by: Tim Ross <tim.ross@goteleport.com>
okraport
force-pushed
the
okraport/tctl-top-teleport-config
branch
from
115e8e3 to
d7235a4
Compare
Contributor
Author
|
Tested locally with And |
okraport
force-pushed
the
okraport/tctl-top-teleport-config
branch
2 times, most recently
from
59bfad2 to
8be697d
Compare
Contributor
Author
|
Closing in favour of #57312 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change moves the tctl configuration parsing
to be done before running the selected command and not be part of client init. This means commands
that do not need a client can access the config
such as
tctl topwhen using socket mode.