MWI: Warn when including Root CA in issuer override chain#57146
Merged
strideynet merged 3 commits intomasterfrom Jul 25, 2025
Merged
MWI: Warn when including Root CA in issuer override chain#57146strideynet merged 3 commits intomasterfrom
strideynet merged 3 commits intomasterfrom
Conversation
strideynet
commented
Jul 24, 2025
strideynet
commented
Jul 24, 2025
espadolini
approved these changes
Jul 24, 2025
Contributor
espadolini
left a comment
espadolini
left a comment
There was a problem hiding this comment.
Should we also warn if the chain isn't made of issuer-issuee pairs?
Co-authored-by: Edoardo Spadolini <edoardo.spadolini@goteleport.com>
Contributor
Author
I'll leave that out of scope for now since I think that's a less likely "mistake" to be made - if we see more uptake of the feature we can probably think about adding a more comprehensive suite of "checks". |
boxofrad
approved these changes
Jul 25, 2025
Contributor
|
@strideynet See the table below for backport results.
|
This was referenced Jul 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #57136
Additionally, adds a
--dry-runmode that outputs the resource that would have been created, without actually creating it.changelog: tctl will now warn the user when importing a SPIFFE issuer override chain that contains the root CA