Fix CTMU re-execution downgraded version#57072
Merged
Conversation
…rectory must disable further re-execution
creack
approved these changes
Jul 23, 2025
hugoShaka
approved these changes
Jul 23, 2025
public-teleport-github-review-bot
bot
removed request for
nklaassen and
sclevine
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Contributor
This was referenced Jul 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces a fix for re-execution in v2 client tool-managed updates, incorporating caching logic.
Since v2 no longer supports a static path for updated client tools (e.g., ~/.tsh/bin/tsh), we need to block any second re-execution from the tools directory.
For example, if version 17.5.1 is installed and updated to 17.6.0, but the cluster requires 17.5.4, the last version should block re-execution and must not allow triggering 17.6.0 again
Related: #54563
changelog: Fixed client tools managed updates downgrade to older version