[v17] MWI: Fall back to registering without an existing auth client#57062
Merged
timothyb89 merged 7 commits intobranch/v17from Jul 28, 2025
Merged
[v17] MWI: Fall back to registering without an existing auth client#57062timothyb89 merged 7 commits intobranch/v17from
timothyb89 merged 7 commits intobranch/v17from
Conversation
This tweaks joining logic to allow clients that provided an existing auth client (i.e. bots, used to verify bot instance IDs between cert refreshes) to fall back to not using that auth client if said client appears to be broken. It attempts to perform a ping, and if the ping fails, proceeds as if no existing client was provided.
This adds an explicit check for an expired identity during renewal. If expired, the existing auth client will not be used.
github-actions
bot
requested review from
boxofrad,
strideynet,
thedevelopnik and
zmb3
Contributor
Author
|
Note: I'll be appending #57063 to this PR once its merged. |
strideynet
approved these changes
Jul 23, 2025
boxofrad
approved these changes
Jul 23, 2025
public-teleport-github-review-bot
bot
removed request for
thedevelopnik and
zmb3
The `Expiry()` function was trying to parse DER-encoded data in the `tls.Certificate` as PEM, causing a silent failure. This method was not used until #56927 but failed every time as it was trying to parse certificates using the wrong encoding type.
Contributor
Author
|
I've cherry-picked 03b5b4d into this branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport #56927 to branch/v17
changelog: Machine and Workload ID: The
tbotclient will now discard expired identities if needed during renewal to allow automatic recovery without restarting the process