feat(web): Add Instances to Bot Details by nicholasmarais1158 · Pull Request #57023 · gravitational/teleport

nicholasmarais1158 · 2025-07-22T12:22:20Z

Summary

This change adds bot instance to the bot details page. The panel loads it own data (separate from the page) and uses in infinite query to add pages to the result set. Instead of the page growing and scrolling, content scrolls within it's column/panel and the page remains full-height at all time.

Depends on: #56901
Designs: Figma link
RFD: RFD0217 - Bot Details (web)
Updates: #47342

Changes

Add OS to bot instance summary
~~Add semver package dependency~~ - using shared utils instead (courtesy of Add logic to resolve auto-update status in Connect #56806 thanks @gzdunek 🙌 )
~~Add sorting icons~~ Moved to feat(web): Add Join Tokens panel to Bot Details #56901
Add outlined Label variants
Update bot details stories
Scroll content panels instead of whole page
Add bot instance panel with infinite query
~~Extract a JoinMethodIcon component~~ Moved to feat(web): Add Join Tokens panel to Bot Details #56901
Expose cluster auth version through user context
Add useClusterVersion hook with diff util
Update windows logo (ResourceIcon component)

Demo

Screen.Recording.2025-07-22.at.13.05.36.mov

…rais1158/feat/bot-instances-web

gzdunek · 2025-07-25T15:08:13Z

+       * upgrade-major - the client is one version behind.
+       * upgrade-minor - the major version is the same, but older on minor or patch.
+       */
+      reason: 'match' | 'upgrade-major' | 'upgrade-minor';


This much nicer than what I had 👍

# Conflicts: # web/packages/teleport/src/Bots/Details/BotDetails.story.tsx # web/packages/teleport/src/Bots/Details/BotDetails.test.tsx # web/packages/teleport/src/Bots/Details/BotDetails.tsx

backport-bot-workflows · 2025-07-30T09:14:45Z

@nicholasmarais1158 See the table below for backport results.

Branch	Result
branch/v17	Failed
branch/v18	Failed

* RPC and cache * API * Update rfc0217 * Remove unnecessary copy * Fix import ordering * Fix cache bypass issue * Add context to unmarshal error * Wrap page_size parse error * Keep backend range logic consistent * feat(web): Add Join Tokens panel to Bot Details * Copy correction * Remove unneeded alert action * Handle outdated proxy error * Extend tests * Rename * Use `tokens.list` for access to tokens page (instead of `tokens.create`) * Add outline label variants * Add `semver` dep to teleport package * Add `useClusterVersion` hook * Expose heartbeat OS * Add sorting icons * Add `JoinMethodIcon` component * Add bot instances to Bot Details * Missing lock content * Fix scroll container * Scroll to top on sort * Remove unused import * Extract join method icons to component * Add mission join token icons/logos * Use OS logos (update windows) * Save some lines 😮‍💨 * Unused imports * Use shared semver * Fix exhaustive check * Re-export new Label variants * Correct version compatibility logic and messaging * Improve error state UX * Use `H2` * Reduce lines * Reduce lines (more) * Fix tests and lint * Fix grid alignment * Remove unnecessary margin 0 * Clarify roles container * Improve type safety of sort state * Remove unnecessary wrappers * Improve `useClusterVersion` * Add sorting icons (used later) * Rename `check()` * Correct newer version messaging # Conflicts: # web/packages/design/src/ResourceIcon/assets/windows-dark.svg # web/packages/design/src/ResourceIcon/assets/windows-light.svg # web/packages/shared/utils/semVer.ts # web/packages/teleport/src/Bots/Details/BotDetails.test.tsx # web/packages/teleport/src/Bots/Edit/EditDialog.test.tsx

* RPC and cache * API * Update rfc0217 * Remove unnecessary copy * Fix import ordering * Fix cache bypass issue * Add context to unmarshal error * Wrap page_size parse error * Keep backend range logic consistent * feat(web): Add Join Tokens panel to Bot Details * Copy correction * Remove unneeded alert action * Handle outdated proxy error * Extend tests * Rename * Use `tokens.list` for access to tokens page (instead of `tokens.create`) * Add outline label variants * Add `semver` dep to teleport package * Add `useClusterVersion` hook * Expose heartbeat OS * Add sorting icons * Add `JoinMethodIcon` component * Add bot instances to Bot Details * Missing lock content * Fix scroll container * Scroll to top on sort * Remove unused import * Extract join method icons to component * Add mission join token icons/logos * Use OS logos (update windows) * Save some lines 😮‍💨 * Unused imports * Use shared semver * Fix exhaustive check * Re-export new Label variants * Correct version compatibility logic and messaging * Improve error state UX * Use `H2` * Reduce lines * Reduce lines (more) * Fix tests and lint * Fix grid alignment * Remove unnecessary margin 0 * Clarify roles container * Improve type safety of sort state * Remove unnecessary wrappers * Improve `useClusterVersion` * Add sorting icons (used later) * Rename `check()` * Correct newer version messaging # Conflicts: # web/packages/design/src/ResourceIcon/assets/windows-dark.svg # web/packages/design/src/ResourceIcon/assets/windows-light.svg # web/packages/shared/utils/semVer.ts # web/packages/teleport/src/Bots/Edit/EditDialog.test.tsx

* feat(web): Add Instances to Bot Details (#57023) * RPC and cache * API * Update rfc0217 * Remove unnecessary copy * Fix import ordering * Fix cache bypass issue * Add context to unmarshal error * Wrap page_size parse error * Keep backend range logic consistent * feat(web): Add Join Tokens panel to Bot Details * Copy correction * Remove unneeded alert action * Handle outdated proxy error * Extend tests * Rename * Use `tokens.list` for access to tokens page (instead of `tokens.create`) * Add outline label variants * Add `semver` dep to teleport package * Add `useClusterVersion` hook * Expose heartbeat OS * Add sorting icons * Add `JoinMethodIcon` component * Add bot instances to Bot Details * Missing lock content * Fix scroll container * Scroll to top on sort * Remove unused import * Extract join method icons to component * Add mission join token icons/logos * Use OS logos (update windows) * Save some lines 😮‍💨 * Unused imports * Use shared semver * Fix exhaustive check * Re-export new Label variants * Correct version compatibility logic and messaging * Improve error state UX * Use `H2` * Reduce lines * Reduce lines (more) * Fix tests and lint * Fix grid alignment * Remove unnecessary margin 0 * Clarify roles container * Improve type safety of sort state * Remove unnecessary wrappers * Improve `useClusterVersion` * Add sorting icons (used later) * Rename `check()` * Correct newer version messaging # Conflicts: # web/packages/design/src/ResourceIcon/assets/windows-dark.svg # web/packages/design/src/ResourceIcon/assets/windows-light.svg # web/packages/shared/utils/semVer.ts # web/packages/teleport/src/Bots/Details/BotDetails.test.tsx # web/packages/teleport/src/Bots/Edit/EditDialog.test.tsx * Run `pnpm process-icons` * Fix tests

nicholasmarais1158 added 28 commits July 16, 2025 13:20

RPC and cache

ffe7b3e

API

e2b8277

Update rfc0217

ba0cc5e

Remove unnecessary copy

3382643

Fix import ordering

fd81804

Fix cache bypass issue

ee1d5e9

Merge branch 'master' into nicholasmarais1158/feat/bot-tokens-api

3f22dfe

Add context to unmarshal error

34841a6

Wrap page_size parse error

e6aedff

Keep backend range logic consistent

fe5ad69

feat(web): Add Join Tokens panel to Bot Details

b50542d

Copy correction

6412069

Remove unneeded alert action

93fd018

Handle outdated proxy error

fe7b24f

Extend tests

e5e57fc

Rename

e336f84

Use tokens.list for access to tokens page (instead of tokens.create)

5063cbb

Add outline label variants

b28b66a

Add semver dep to teleport package

eda80bd

Add useClusterVersion hook

4597088

Expose heartbeat OS

93c35df

Add sorting icons

3faf420

Add JoinMethodIcon component

a66c869

Add bot instances to Bot Details

81eaee2

Merge branch 'master' into nicholasmarais1158/feat/bot-instances-web

0a208ef

Missing lock content

4fac800

Fix scroll container

a0ed511

Scroll to top on sort

957d2cf

nicholasmarais1158 self-assigned this Jul 22, 2025

nicholasmarais1158 added the machine-id label Jul 22, 2025

nicholasmarais1158 added 5 commits July 25, 2025 10:12

Remove unnecessary margin 0

d8f20d4

Clarify roles container

2d72d7a

Improve type safety of sort state

a0a09a9

Remove unnecessary wrappers

99cddc0

Improve useClusterVersion

cd4bf69

nicholasmarais1158 requested a review from gzdunek July 25, 2025 11:08

nicholasmarais1158 added 3 commits July 25, 2025 12:42

Add sorting icons (used later)

834fb86

Merge branch 'master' into nicholasmarais1158/feat/bot-tokens-web

8c69299

Merge branch 'nicholasmarais1158/feat/bot-tokens-web' into nicholasma…

24dc82f

…rais1158/feat/bot-instances-web

gzdunek approved these changes Jul 25, 2025

View reviewed changes

nicholasmarais1158 added 2 commits July 28, 2025 09:27

Rename check()

ea38edb

Correct newer version messaging

8b88e2e

nicholasmarais1158 mentioned this pull request Jul 28, 2025

feat(web): Link to Bot Details #57210

Merged

Base automatically changed from nicholasmarais1158/feat/bot-tokens-web to master July 28, 2025 17:45

Merge branch 'master' into nicholasmarais1158/feat/bot-instances-web

b0e9567

# Conflicts: # web/packages/teleport/src/Bots/Details/BotDetails.story.tsx # web/packages/teleport/src/Bots/Details/BotDetails.test.tsx # web/packages/teleport/src/Bots/Details/BotDetails.tsx

strideynet approved these changes Jul 30, 2025

View reviewed changes

public-teleport-github-review-bot bot removed the request for review from rudream July 30, 2025 08:24

nicholasmarais1158 added this pull request to the merge queue Jul 30, 2025

Merged via the queue into master with commit 30b4500 Jul 30, 2025
44 checks passed

nicholasmarais1158 deleted the nicholasmarais1158/feat/bot-instances-web branch July 30, 2025 09:13

nicholasmarais1158 mentioned this pull request Aug 1, 2025

[v18] feat(web): Add Instances to Bot Details (#57023) #57445

Merged

nicholasmarais1158 mentioned this pull request Aug 1, 2025

[v17] feat(web): Add Instances to Bot Details (#57023) #57450

Merged

This was referenced Aug 5, 2025

[v18] feat(web): Link to Bot Details (#57210) #57542

Merged

[v17] feat(web): Link to Bot Details (#57210) #57543

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(web): Add Instances to Bot Details#57023

feat(web): Add Instances to Bot Details#57023
nicholasmarais1158 merged 62 commits intomasterfrom
nicholasmarais1158/feat/bot-instances-web

nicholasmarais1158 commented Jul 22, 2025 •

edited

Loading

Uh oh!

gzdunek Jul 25, 2025

Uh oh!

nicholasmarais1158 Jul 28, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

backport-bot-workflows bot commented Jul 30, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

nicholasmarais1158 commented Jul 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Changes

Demo

Uh oh!

gzdunek Jul 25, 2025

Choose a reason for hiding this comment

Uh oh!

nicholasmarais1158 Jul 28, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

backport-bot-workflows bot commented Jul 30, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

nicholasmarais1158 commented Jul 22, 2025 •

edited

Loading