Prevent sending TDP messages in chunks during desktop sessions in Connect#57022
Merged
Prevent sending TDP messages in chunks during desktop sessions in Connect#57022
Conversation
gzdunek
requested review from
ravicious and
rosstimothy
and removed request for
nklaassen and
vapopov
ravicious
approved these changes
Jul 22, 2025
zmb3
reviewed
Jul 22, 2025
zmb3
approved these changes
Jul 24, 2025
public-teleport-github-review-bot
bot
removed the request for review
from rosstimothy
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Contributor
This was referenced Jul 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #56921
Disables chunking TDP messages between tsh daemon and Electron, as described in #56921 (comment).
Clipboard data sent through this connection is limited to a maximum size of 1 MB, which is a restriction in the TDP message decoder.
teleport/lib/srv/desktop/tdp/proto.go
Line 1791 in 22ce46d
changelog: Fixed a crash in Teleport Connect that could occur when copying large clipboard content during desktop sessions