Merged
Conversation
zmb3
approved these changes
Jul 17, 2025
marcoandredinis
approved these changes
Jul 18, 2025
public-teleport-github-review-bot
Bot
removed request for
capnspacehook,
ravicious and
sclevine
Contributor
|
@hugoShaka See the table below for backport results.
|
This was referenced Jul 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a user-reported bug in the
oneoff.shscript when running against MacOS.We got lucky and this bug only rendered the FIPS test ineffective and did not break the whole script.
This PR fixes the script and adds MacOS test coverage (regular MacOS should work, MacOS FIPS should fail). Without the script fix, the "MacOS + FIPS" test doesn't pass.
Changelog: Fix a bug in the Teleport install scripts when running on MacOS. The install scripts now error instead of trying to install non existing MacOS FIPS binaries.