Fix /var/log/wtmp not updating on session exit#56916
Closed
Conversation
espadolini
reviewed
Jul 17, 2025
Comment on lines
+343
to
+345
| // For reasons beyond me, updwtmp() returns ENOENT even when it's completely | ||
| // successful. When that happens, this function checks if f's target file was | ||
| // modified. If it was, assume that the ENOENT is spurious. |
Contributor
There was a problem hiding this comment.
Can we check if the entry we wanted to add is in the file, instead? Basing this off of the mtime is racey, at a minimum.
rosstimothy
requested changes
Jul 18, 2025
Contributor
rosstimothy
left a comment
rosstimothy
left a comment
There was a problem hiding this comment.
Can we come up with a solution to this issue that doesn't result in spurious ENOENTs?
Contributor
Author
|
closed in favor of #57875 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change fixes a bug where the user accounting log file (/var/log/wtmp) would not be updated when a session finished.
Fixes #54606.
Changelog: Fixed /var/log/wtmp not updating on session exit