Skip to content

Fix AccessListService.UpsertAccessList MemberOf update#56760

Merged
kopiczko merged 1 commit intomasterfrom
kopiczko/access_list__member_of
Jul 18, 2025
Merged

Fix AccessListService.UpsertAccessList MemberOf update#56760
kopiczko merged 1 commit intomasterfrom
kopiczko/access_list__member_of

Conversation

@kopiczko
Copy link
Copy Markdown
Contributor

@kopiczko kopiczko commented Jul 14, 2025

Related test supporting correctness of access calculation (which wasn't affected): https://github.com/gravitational/teleport.e/pull/6886

Backports:

changelog: Fix nested access list hierarchy propagation in case of tctl using UpsertAccessList API call.

@kopiczko kopiczko requested a review from smallinsky July 14, 2025 14:03
@kopiczko kopiczko force-pushed the kopiczko/access_list__member_of branch from d5c5ef9 to 3d7a2c0 Compare July 14, 2025 14:04
@kopiczko kopiczko force-pushed the kopiczko/access_list__member_of branch from 3d7a2c0 to 0200ec3 Compare July 14, 2025 14:15
@kopiczko kopiczko marked this pull request as ready for review July 14, 2025 15:03
Comment thread lib/services/local/access_list.go Outdated
Comment thread lib/services/local/access_list_test.go Outdated
Comment thread lib/services/local/access_list_test.go Outdated
Comment thread lib/services/local/access_list.go
Comment thread lib/services/local/access_list.go Outdated
Comment thread lib/services/local/access_list_test.go
Comment thread lib/services/local/access_list_test.go
Comment thread lib/services/local/access_list_test.go
Comment thread lib/services/local/access_list_test.go
@github-actions github-actions bot requested review from rudream and tigrato July 14, 2025 15:03
@kopiczko kopiczko force-pushed the kopiczko/access_list__member_of branch from 0200ec3 to 399484f Compare July 14, 2025 15:30
@kopiczko kopiczko requested a review from smallinsky July 14, 2025 15:30
@kopiczko kopiczko force-pushed the kopiczko/access_list__member_of branch from 399484f to a7a8134 Compare July 14, 2025 15:38
@kopiczko
Copy link
Copy Markdown
Contributor Author

@smallinsky PTALA

Comment thread lib/services/local/access_list.go
@kopiczko kopiczko added the no-changelog Indicates that a PR does not require a changelog entry label Jul 14, 2025
@kopiczko kopiczko force-pushed the kopiczko/access_list__member_of branch from a7a8134 to 0bda1ba Compare July 14, 2025 20:48
@kopiczko
Copy link
Copy Markdown
Contributor Author

Friendly ping @rudream @tigrato

Comment thread lib/services/local/access_list_test.go Outdated
@kopiczko kopiczko force-pushed the kopiczko/access_list__member_of branch from 0bda1ba to 6664743 Compare July 15, 2025 13:34
@kopiczko kopiczko force-pushed the kopiczko/access_list__member_of branch from 6664743 to a39c88d Compare July 15, 2025 13:34
@kopiczko
Copy link
Copy Markdown
Contributor Author

Friendly ping @rudream @tigrato

@kopiczko kopiczko added this pull request to the merge queue Jul 18, 2025
Merged via the queue into master with commit 8c2b13d Jul 18, 2025
40 checks passed
@kopiczko kopiczko deleted the kopiczko/access_list__member_of branch July 18, 2025 21:43
@backport-bot-workflows
Copy link
Copy Markdown
Contributor

@kopiczko See the table below for backport results.

Branch Result
branch/v17 Failed
branch/v18 Failed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport/branch/v17 backport/branch/v18 no-changelog Indicates that a PR does not require a changelog entry size/md

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants