Skip to content

MWI: Fix flaky test for bound keypair generation counter #56732

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
timothyb89 merged 2 commits into from
Jul 12, 2025
Merged

MWI: Fix flaky test for bound keypair generation counter #56732

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ddb2661
MWI: Fix flaky test for bound keypair generation counter
timothyb89 Jul 11, 2025
e00cdea
Apply suggestions from code review
timothyb89 Jul 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions lib/auth/join_bound_keypair_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ import (
"github.com/go-jose/go-jose/v3/jwt"
"github.com/gravitational/trace"
"github.com/jonboulle/clockwork"
"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"

"github.com/gravitational/teleport/api/client"
Expand Down Expand Up @@ -1109,8 +1110,10 @@ func TestServer_RegisterUsingBoundKeypairMethod_GenerationCounter(t *testing.T)
require.Contains(t, locks[0].Message(), "certificate generation mismatch")

// Using the previously working client, make sure API calls no longer work.
_, err = client.Ping(ctx)
require.ErrorContains(t, err, "access denied")
require.EventuallyWithT(t, func(t *assert.CollectT) {
_, err = client.Ping(ctx)
assert.ErrorContains(t, err, "access denied")
}, 5*time.Second, 100*time.Millisecond)
}

func TestServer_RegisterUsingBoundKeypairMethod_JoinStateFailure(t *testing.T) {
Expand Down
Loading