Skip to content

followup: Remove unused auth.ValidateClientRedirect function #56652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Joerger merged 1 commit into from
Jul 10, 2025
Merged

followup: Remove unused auth.ValidateClientRedirect function #56652

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 0 additions & 21 deletions lib/auth/github.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1008,27 +1008,6 @@ func (a *Server) createGithubUser(ctx context.Context, p *CreateUserParams, dryR
return user, nil
}

// ValidateClientRedirect checks a desktop client redirect URL for SSO logins
// against some (potentially nil) settings from an auth connector; in the
// current implementation, that means either "http" schema with a hostname of
// "localhost", "127.0.0.1", or "::1" and a path of "/callback" (with any port),
// or "https" schema with a hostname that matches one in the https_hostname
// list, a path of "/callback" and either an empty port or explicitly 443. The
// settings are ignored and only localhost URLs are allowed if we're using an
// ephemeral connector (in the SSO testing flow). If the insecure_allowed_cidr_ranges
// list is non-empty URLs in both the "http" and "https" schema are allowed
// if the hostname is an IP address that is contained in a specified CIDR
// range on any port.
//
// TODO(Joerger): Replaced by [sso.ValidateClientRedirect], remove once /e no longer depends on it
func ValidateClientRedirect(clientRedirect string, ssoTestFlow bool, settings *types.SSOClientRedirectSettings) error {
ceremonyType := sso.CeremonyTypeLogin
if ssoTestFlow {
ceremonyType = sso.CeremonyTypeTest
}
return sso.ValidateClientRedirect(clientRedirect, ceremonyType, settings)
}

// populateGithubClaims builds a GithubClaims using queried
// user, organization and teams information.
func populateGithubClaims(user *GithubUserResponse, teams []GithubTeamResponse) (*types.GithubClaims, error) {
Expand Down
Loading