Fix Workload API handling of SVID renewal interval#56626
Merged
strideynet merged 1 commit intomasterfrom Jul 10, 2025
Merged
Conversation
timothyb89
approved these changes
Jul 9, 2025
boxofrad
approved these changes
Jul 10, 2025
Contributor
|
@strideynet See the table below for backport results.
|
This was referenced Jul 10, 2025
strideynet
added a commit
that referenced
this pull request
Jul 10, 2025
marcoandredinis
pushed a commit
that referenced
this pull request
Jul 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When I introduced the CRL functionality, I introduced a bug where the broadcasting of a new CRL would reset the timer for renewing the SVIDs. In cases where the CRL renewal interval was shorter than the SVID renewal interval, this would lead to the SVIDs never being renewed.
I've resolved this bug by using a proper
time.Timerinstead of usingtime.Afteron each iteration.changelog: Fix
tbotSPIFFE Workload API failing to renew SPIFFE SVIDs