-
Notifications
You must be signed in to change notification settings - Fork 2.1k
[vnet] feat: SSH usage reporting #56537
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 1 commit
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||||
|---|---|---|---|---|---|---|---|---|
|
|
@@ -134,6 +134,11 @@ func (p *vnetClientApplication) GetDialOptions(ctx context.Context, profileName | |||||||
| return dialOpts, nil | ||||||||
| } | ||||||||
|
|
||||||||
| // OnNewSSHSession gets called before each VNet SSH connection. It's a noop as | ||||||||
| // tsh doesn't need to do anything extra here. | ||||||||
| func (p *vnetClientApplication) OnNewSSHSession(ctx context.Context, profileName, targetClusterName string) { | ||||||||
| } | ||||||||
|
|
||||||||
| // OnNewConnection gets called before each VNet connection. It's a noop as tsh doesn't need to do | ||||||||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Now that I think about it, This name is used in many places so renaming it might be a bit of a pain, if you don't feel like taking care of this right now, then could you update the comments at least? teleport/proto/teleport/lib/vnet/v1/client_application_service.proto Lines 47 to 49 in 63be404
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. i did the rename |
||||||||
| // anything extra here. | ||||||||
| func (p *vnetClientApplication) OnNewConnection(_ context.Context, _ *vnetv1.AppKey) error { | ||||||||
|
|
||||||||
Uh oh!
There was an error while loading. Please reload this page.