Bump jest-environment-jsdom from 29.7.0 to 30.0.2#56294
Merged
Conversation
Contributor
Author
|
The |
7f82e1c to
7def56e
Compare
--- updated-dependencies: - dependency-name: jest-environment-jsdom dependency-version: 30.0.2 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
7def56e to
6d4fc1d
Compare
Contributor
|
jsdom no longer allows mocking To fix this, I'm passing |
gzdunek
approved these changes
Jul 7, 2025
ravicious
approved these changes
Jul 7, 2025
Member
ravicious
left a comment
There was a problem hiding this comment.
Good stuff. Thanks for taking care of the override as well and refactoring window.location usage.
…sdom-30.0.2 # Conflicts: # pnpm-lock.yaml # web/packages/build/package.json
This was referenced Jan 8, 2026
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 8, 2026
…ost (#62677) * Device Trust: Append query params to the processed redirect_uri * teleterm: Do not construct query params by hand This messes up the encoding. When interpolating redirect_uri within a string, the URL is simply not going to get encoded. This means that if redirect_uri is something like "https://example.com/hello?foo=1&bar=2", "bar=2" is going to be interpreted as one of the query param of the returned URL, not as one of the query params of redirect_uri. * makeDeepLinkWithSafeInput: Use URLSearchParams to construct query params This is not quite necessary, the previous code was good enough. But just to be safe, instead of constructing query params manually we can just delegate it to URLSearchParams. * teleterm deep links: Add tests for redirect_uri with query params * Update jest * Backport changes needed for jest-environment-jsdom update Those come from #56294. --------- Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 8, 2026
…ost (#62678) * Device Trust web: Ensure query params of redirect URL are not lost * Device Trust: Append query params to the processed redirect_uri * teleterm: Do not construct query params by hand This messes up the encoding. When interpolating redirect_uri within a string, the URL is simply not going to get encoded. This means that if redirect_uri is something like "https://example.com/hello?foo=1&bar=2", "bar=2" is going to be interpreted as one of the query param of the returned URL, not as one of the query params of redirect_uri. * makeDeepLinkWithSafeInput: Use URLSearchParams to construct query params This is not quite necessary, the previous code was good enough. But just to be safe, instead of constructing query params manually we can just delegate it to URLSearchParams. * teleterm deep links: Add tests for redirect_uri with query params * Update jest * Backport changes needed for jest-environment-jsdom update Those come from #56294. --------- Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)