Skip to content

Bump jest-environment-jsdom from 29.7.0 to 30.0.2#56294

Merged
ravicious merged 7 commits intomasterfrom
dependabot/npm_and_yarn/jest-environment-jsdom-30.0.2
Jul 7, 2025
Merged

Bump jest-environment-jsdom from 29.7.0 to 30.0.2#56294
ravicious merged 7 commits intomasterfrom
dependabot/npm_and_yarn/jest-environment-jsdom-30.0.2

Conversation

@dependabot
Copy link
Copy Markdown
Contributor

@dependabot dependabot bot commented on behalf of github Jul 1, 2025

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot requested a review from avatus as a code owner July 1, 2025 12:06
@dependabot dependabot bot requested a review from ryanclark July 1, 2025 12:06
@dependabot dependabot bot requested review from gzdunek and ravicious as code owners July 1, 2025 12:06
@dependabot @github
Copy link
Copy Markdown
Contributor Author

dependabot bot commented on behalf of github Jul 1, 2025

The reviewers field in the dependabot.yml file will be removed soon. Please use the code owners file to specify reviewers for Dependabot PRs. For more information, see this blog post.

@dependabot dependabot bot added dependencies Pull requests that update a dependency file no-changelog Indicates that a PR does not require a changelog entry ui labels Jul 1, 2025
@gzdunek gzdunek self-assigned this Jul 1, 2025
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/jest-environment-jsdom-30.0.2 branch 2 times, most recently from 7f82e1c to 7def56e Compare July 3, 2025 11:19
---
updated-dependencies:
- dependency-name: jest-environment-jsdom
  dependency-version: 30.0.2
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/jest-environment-jsdom-30.0.2 branch from 7def56e to 6d4fc1d Compare July 3, 2025 14:44
@gzdunek
Copy link
Copy Markdown
Contributor

gzdunek commented Jul 7, 2025

jsdom no longer allows mocking window.location https://jestjs.io/blog/2025/06/04/jest-30#known-issues.

To fix this, I'm passing location as an argument, so it can be overwritten in tests. Honestly, I think it’s cleaner. Mocking window.location has always been a bit of a pain.

Copy link
Copy Markdown
Member

@ravicious ravicious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff. Thanks for taking care of the override as well and refactoring window.location usage.

@ravicious ravicious added this pull request to the merge queue Jul 7, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Jul 7, 2025
…sdom-30.0.2

# Conflicts:
#	pnpm-lock.yaml
#	web/packages/build/package.json
@ravicious ravicious enabled auto-merge July 7, 2025 10:07
@ravicious ravicious added this pull request to the merge queue Jul 7, 2025
Merged via the queue into master with commit dbb20a7 Jul 7, 2025
40 checks passed
@ravicious ravicious deleted the dependabot/npm_and_yarn/jest-environment-jsdom-30.0.2 branch July 7, 2025 10:28
ravicious pushed a commit that referenced this pull request Jan 8, 2026
ravicious pushed a commit that referenced this pull request Jan 8, 2026
github-merge-queue bot pushed a commit that referenced this pull request Jan 8, 2026
…ost (#62677)

* Device Trust: Append query params to the processed redirect_uri

* teleterm: Do not construct query params by hand

This messes up the encoding. When interpolating redirect_uri within a
string, the URL is simply not going to get encoded. This means that if
redirect_uri is something like "https://example.com/hello?foo=1&bar=2",
"bar=2" is going to be interpreted as one of the query param of the
returned URL, not as one of the query params of redirect_uri.

* makeDeepLinkWithSafeInput: Use URLSearchParams to construct query params

This is not quite necessary, the previous code was good enough. But just
to be safe, instead of constructing query params manually we can just
delegate it to URLSearchParams.

* teleterm deep links: Add tests for redirect_uri with query params

* Update jest

* Backport changes needed for jest-environment-jsdom update

Those come from #56294.

---------

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
github-merge-queue bot pushed a commit that referenced this pull request Jan 8, 2026
…ost (#62678)

* Device Trust web: Ensure query params of redirect URL are not lost

* Device Trust: Append query params to the processed redirect_uri

* teleterm: Do not construct query params by hand

This messes up the encoding. When interpolating redirect_uri within a
string, the URL is simply not going to get encoded. This means that if
redirect_uri is something like "https://example.com/hello?foo=1&bar=2",
"bar=2" is going to be interpreted as one of the query param of the
returned URL, not as one of the query params of redirect_uri.

* makeDeepLinkWithSafeInput: Use URLSearchParams to construct query params

This is not quite necessary, the previous code was good enough. But just
to be safe, instead of constructing query params manually we can just
delegate it to URLSearchParams.

* teleterm deep links: Add tests for redirect_uri with query params

* Update jest

* Backport changes needed for jest-environment-jsdom update

Those come from #56294.

---------

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file no-changelog Indicates that a PR does not require a changelog entry ui

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants