Avoid counterproductive checks in IsUserAuthority and IsHostAuthority#56250
Merged
espadolini merged 1 commit intomasterfrom Jun 30, 2025
Merged
Avoid counterproductive checks in IsUserAuthority and IsHostAuthority#56250espadolini merged 1 commit intomasterfrom
IsUserAuthority and IsHostAuthority#56250espadolini merged 1 commit intomasterfrom
Conversation
espadolini
added
the
no-changelog
This was referenced Jun 30, 2025
rosstimothy
approved these changes
Jun 30, 2025
fheinecke
approved these changes
Jun 30, 2025
public-teleport-github-review-bot
Bot
removed request for
juliaogris and
ravicious
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the special handling for
*ssh.Certificateauthorities in theIsHostAuthorityandIsUserAuthoritycallbacks used byx/crypto/ssh.CertCheckeras it's a condition that should never happen anyway, and can lead to accepting invalid credentials as legitimate.