[v16] Prevent WindowsDesktops from exceeding max message size#56233
Merged
rosstimothy merged 1 commit intobranch/v16from Jun 30, 2025
Merged
[v16] Prevent WindowsDesktops from exceeding max message size#56233rosstimothy merged 1 commit intobranch/v16from
rosstimothy merged 1 commit intobranch/v16from
Conversation
rosstimothy
force-pushed
the
tross/backport-56129/v16
branch
from
3a95fb6 to
bd303b0
Compare
- A new ListWindowsDesktops RPC has been added to the auth gRPC service. - The cache has been updated to use List instead of GetAll methods for WindowsDesktops and WindowsDesktopServices. - The ListWindowsDesktopServices implementation in the cache is now applying filters if provided. - tctl get windows_desktop/foo and tctl get windows_desktop_services/foo have been updated to rely on server side filtering for instead of attempting client side filtering when retrieving a single resource. - tctl desktop ls has been updated to rely on listing instead of GetWindowsDesktops.
rosstimothy
force-pushed
the
tross/backport-56129/v16
branch
from
bd303b0 to
9a732df
Compare
espadolini
approved these changes
Jun 30, 2025
fheinecke
approved these changes
Jun 30, 2025
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport #56129 to branch/v16
Changelog: Update WindowsDesktop and WindowsDesktopService APIs to use pagination to avoid exceeding message size limitations.