Skip to content

Revert "[v17] Update piv-go to v2.3.0"#55960

Merged
Joerger merged 1 commit intobranch/v17from
revert-55901-joerger/v17/update-piv-go
Jun 20, 2025
Merged

Revert "[v17] Update piv-go to v2.3.0"#55960
Joerger merged 1 commit intobranch/v17from
revert-55901-joerger/v17/update-piv-go

Conversation

@Joerger
Copy link
Copy Markdown
Contributor

@Joerger Joerger commented Jun 20, 2025

Reverts #55901

Causes a build failure with the PIV build tag:

lib/hardwarekey/hardwarekey.go:38:61: cannot use attestation (variable of type *"github.com/go-piv/piv-go/piv".Attestation) as *"github.com/go-piv/piv-go/v2/piv".Attestation value in argument to keys.GetPrivateKeyPolicyFromAttestation
make[2]: *** [build/teleport] Error 1

https://github.com/gravitational/teleport.e/pull/6256 needs to be backported to v17 before this backport can be re-opened

@Joerger Joerger added the no-changelog Indicates that a PR does not require a changelog entry label Jun 20, 2025
@public-teleport-github-review-bot public-teleport-github-review-bot Bot removed the request for review from rosstimothy June 20, 2025 18:55
@Joerger Joerger enabled auto-merge June 20, 2025 19:05
@Joerger Joerger added this pull request to the merge queue Jun 20, 2025
Merged via the queue into branch/v17 with commit bb74e65 Jun 20, 2025
44 of 46 checks passed
@Joerger Joerger deleted the revert-55901-joerger/v17/update-piv-go branch June 20, 2025 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport no-changelog Indicates that a PR does not require a changelog entry size/sm

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants