Conversation
rudream
added
no-changelog
zmb3
reviewed
Jun 20, 2025
gzdunek
approved these changes
Jun 23, 2025
Contributor
gzdunek
left a comment
gzdunek
left a comment
There was a problem hiding this comment.
I tested it locally, works properly now.
rudream
force-pushed
the
yassine/fix-login-redirect-on-session-expiry
branch
from
d352d79 to
968931d
Compare
kimlisa
approved these changes
Jun 24, 2025
kimlisa
approved these changes
Jun 26, 2025
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This PR resolves #50431
This PR fixes an issue where if a user's session expired, they would not automatically be logged out in the UI and taken back to the login page. The user is now redirected to the login page even if the
api.delete()call returns an error, which happens if the session is expired/invalid.