Add teleport status --is-up-to-date#55646
Merged
Conversation
vapopov
approved these changes
Jun 11, 2025
Contributor
vapopov
left a comment
There was a problem hiding this comment.
I would add a test for this command func Run(args []string) int
Contributor
Author
I'm not a huge fan of testing the whole status thing as it's going to require a full blown mock environment, with a fake config, proxy mock, ... This is basically an integration test and should be in One quick way to add coverage would be to extract a small function: func statusExitCode(ccfg cliConfig, status agent.Status) int {
// ...
}Would this work for you? |
strideynet
approved these changes
Jun 12, 2025
856e39f to
84b2389
Compare
Contributor
|
@hugoShaka See the table below for backport results.
|
This was referenced Jun 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a flag
--is-up-to-dateto theteleport-update statuscommand. In some specific setups, users don't have systemd but still want to write their own logic to update and restart Teleport. See this Slack thread for more context.While we cannot cover every use-case, we can make it easy for users to detect if an update is required. They will then be responsible for triggering the update and reloading/restarting the teleport processes.
Changelog: Adds the the
teleport-update status --is-up-to-dateflag to change the return code based on the update status.