[teleport-update] Use teleport config package to generate systemd services#55499
Merged
[teleport-update] Use teleport config package to generate systemd services#55499
Conversation
sclevine
force-pushed
the
sclevine/autoupdates-systemd-refactor
branch
from
8d3f7db to
48cfda7
Compare
sclevine
force-pushed
the
sclevine/autoupdates-systemd-refactor
branch
from
556bb9a to
445a594
Compare
boxofrad
approved these changes
Jul 1, 2025
sclevine
force-pushed
the
sclevine/autoupdates-systemd-refactor
branch
from
98cea03 to
b23baa7
Compare
sclevine
force-pushed
the
sclevine/autoupdates-systemd-refactor
branch
from
c5f86bf to
f043a9d
Compare
vapopov
approved these changes
Jul 1, 2025
hugoShaka
approved these changes
Jul 3, 2025
public-teleport-github-review-bot
bot
removed the request for review
from nklaassen
Contributor
sclevine
added a commit
that referenced
this pull request
Jul 8, 2025
…vices (#55499) * Refactor systemd services * cleanup * use FIPS in config test * cleanup * prevent large package import * rename testdata file
sclevine
added a commit
that referenced
this pull request
Jul 8, 2025
…vices (#55499) * Refactor systemd services * cleanup * use FIPS in config test * cleanup * prevent large package import * rename testdata file
sclevine
added a commit
that referenced
this pull request
Jul 8, 2025
…vices (#55499) * Refactor systemd services * cleanup * use FIPS in config test * cleanup * prevent large package import * rename testdata file
sclevine
added a commit
that referenced
this pull request
Jul 8, 2025
…vices (#55499) * Refactor systemd services * cleanup * use FIPS in config test * cleanup * prevent large package import * rename testdata file
sclevine
added a commit
that referenced
this pull request
Jul 8, 2025
…vices (#55499) * Refactor systemd services * cleanup * use FIPS in config test * cleanup * prevent large package import * rename testdata file
This was referenced Jul 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR switches
teleport-updateto thelib/config/systemdpackage to generate theteleport.servicesystemd service. This is equivalent to runningteleport install systemdwith the target Teleport version, asteleport-updatealways re-execs the target version ofteleport-updatebefore writing configuration.This PR also refactors teleport-update to support creating a systemd service for each binary. This will be used in a follow-up PR to add support for installing a tbot service and reloading tbot.
Finally, this PR also appends the target version of Teleport to all configuration file headers. This will make it easier for humans to determine which configuration files are being updated, and allows teleport-update to verify which files belong to each version of Teleport.
Note: systemd functions in lib/config are moved into lib/config/systemd to prevent pulling a large number of dependencies into teleport-update (some of which prevent it from building on Linux).
changelog: Append headers to configuration files generated by teleport-update
Goal: https://github.com/gravitational/cloud/issues/13207 (internal)